Skip to content

Commit

Permalink
delete setup.py modifications from an earlier iteration and clarify c…
Browse files Browse the repository at this point in the history
…omments
  • Loading branch information
cosmicexplorer committed Mar 27, 2018
1 parent d6dbe1f commit 61503e6
Showing 1 changed file with 7 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,11 @@ def _native_toolchain(self):

def modify_environment(self, env):
env = self._native_toolchain.modify_environment(env)
# If we're going to be wrapping setup.py-based projects, we really should be
# doing it through a subclass of a distutils UnixCCompiler (in Lib/distutils
# in the CPython source) instead of hoping setup.py knows what to do. The
# default UnixCCompiler from distutils will build a 32/64-bit "fat binary"
# unless you use their undocumented ARCHFLAGS env var, and there may be more
# dragons later on.
env['CC'] = 'gcc'
env['CXX'] = 'g++'
env['ARCHFLAGS'] = '-arch x86_64'
# FIXME: If we're going to be wrapping setup.py-based projects, we really
# should be doing it through a subclass of a distutils UnixCCompiler (in
# Lib/distutils in the CPython source) instead of hoping setup.py knows what
# to do. For example, the default UnixCCompiler from distutils will build a
# 32/64-bit "fat binary" on osx unless you set ARCHFLAGS='-arch x86_64',
# which is totally undocumented. We could probably expose this pretty easily
# as an import to the setup.py.
return env

0 comments on commit 61503e6

Please sign in to comment.