Skip to content

Commit

Permalink
Add clean-all statements to integration tests to gauge flakiness
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Livingston committed Jan 30, 2018
1 parent a787717 commit 8ac832b
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ def test_pants_test(self):
self.assert_success(pants_run)

def test_with_install_requires(self):
command=['run', '{}:main_with_no_conflict'.format(self.superhello_install_requires)]
command=['clean-all', 'run', '{}:main_with_no_conflict'.format(self.superhello_install_requires)]
pants_run = self.run_pants(command=command)
self.assert_success(pants_run)
self.assertIn('United States', pants_run.stdout_data)
command=['binary', '{}:main_with_no_conflict'.format(self.superhello_install_requires)]
command=['clean-all', 'binary', '{}:main_with_no_conflict'.format(self.superhello_install_requires)]
pants_run = self.run_pants(command=command)
self.assert_success(pants_run)
pex = os.path.join(get_buildroot(), 'dist', 'main_with_no_conflict.pex')
Expand All @@ -58,12 +58,12 @@ def test_with_install_requires(self):
os.remove(pex)

def test_with_conflicting_transitive_deps(self):
command=['run', '{}:main_with_conflicting_dep'.format(self.superhello_install_requires)]
command=['clean-all', 'run', '{}:main_with_conflicting_dep'.format(self.superhello_install_requires)]
pants_run = self.run_pants(command=command)
self.assert_failure(pants_run)
self.assertIn('pycountry', pants_run.stderr_data)
self.assertIn('superhello', pants_run.stderr_data)
command=['binary', '{}:main_with_conflicting_dep'.format(self.superhello_install_requires)]
command=['clean-all', 'binary', '{}:main_with_conflicting_dep'.format(self.superhello_install_requires)]
pants_run = self.run_pants(command=command)
self.assert_failure(pants_run)
self.assertIn('pycountry', pants_run.stderr_data)
Expand Down

0 comments on commit 8ac832b

Please sign in to comment.