Skip to content

Commit

Permalink
[internal] Make explicit that we're redownloading Go modules multiple…
Browse files Browse the repository at this point in the history
… times

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
  • Loading branch information
Eric-Arellano committed Oct 25, 2021
1 parent 8a28934 commit 94bea5b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/python/pants/backend/go/util_rules/go_mod.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ async def determine_go_mod_info(
input_digest=sources_digest,
working_dir=go_mod_dir,
description=f"List modules in {go_mod_path}",
# TODO: Fix this!
allow_downloads=True,
),
)

Expand Down
1 change: 1 addition & 0 deletions src/python/pants/backend/go/util_rules/sdk.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ async def setup_go_sdk_process(
argv=[bash.path, go_sdk_run.script.path, *request.command],
env={
GoSdkRunSetup.CHDIR_ENV: request.working_dir or "",
**request.env,
},
input_digest=input_digest,
description=request.description,
Expand Down
2 changes: 2 additions & 0 deletions src/python/pants/backend/go/util_rules/third_party_pkg.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,8 @@ async def compute_third_party_module_metadata(
"Determine metadata for Go third-party module "
f"{request.module_path}@{request.version}"
),
# TODO: Fix this!
allow_downloads=True,
),
)

Expand Down

0 comments on commit 94bea5b

Please sign in to comment.