Skip to content

Commit

Permalink
don't do a pants run on osx (#7278)
Browse files Browse the repository at this point in the history
### Problem

Fixes #7247, catching a case that was otherwise missed.

### Solution

- Don't do a `./pants run` on osx using the gnu toolchain in testing, as it doesn't work yet.

### Result

As noted in #7249, it's strange that that PR passes but the nightly job fails -- it may be nondeterministic.
  • Loading branch information
cosmicexplorer authored Feb 23, 2019
1 parent a86639e commit a87a01b
Showing 1 changed file with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,18 @@ def test_native_compiler_option_sets_integration(self, toolchain_variant):
This target uses the ndebug and asdf option sets.
If either of these are not present (disabled), this test will fail.
"""
# TODO(#6848): this fails when run with gcc on osx as it requires gcc's libstdc++.so.6.dylib to
# be available on the runtime library path.
attempt_pants_run = Platform.create().resolve_for_enum_variant({
'darwin': toolchain_variant.resolve_for_enum_variant({
'gnu': False,
'llvm': True,
}),
'linux': True,
})
if not attempt_pants_run:
return

command = [
'run',
self._binary_target_with_compiler_option_sets
Expand Down

0 comments on commit a87a01b

Please sign in to comment.