rename uncacheable -> side_effecting

src/python/pants/engine/console.py

@@ -36,7 +36,7 @@ def write(self, payload):
 
 class Console:
   """Class responsible for writing text to the console while Pants is running. """
-  uncacheable = True
+  side_effecting = True
 
   def __init__(self, stdout=None, stderr=None, use_colors: bool = True, session: Optional[Any] = None):
     """`stdout` and `stderr` may be explicitly provided when Console is constructed. 

src/python/pants/engine/fs.py

@@ -212,7 +212,7 @@ class UrlToFetch:
 @dataclass(frozen=True)
 class Workspace:
   """Abstract handle for operations that touch the real local filesystem."""
-  uncacheable = True
+  side_effecting = True
   _scheduler: "SchedulerSession"
 
   def materialize_directory(

src/python/pants/engine/interactive_runner.py

@@ -33,7 +33,7 @@ def __post_init__(self):
 @dataclass(frozen=True)
 class InteractiveRunner:
   _scheduler: 'SchedulerSession'
-  uncacheable = True
+  side_effecting = True
 
   def run_local_interactive_process(self, request: InteractiveProcessRequest) -> InteractiveProcessResult:
     ExceptionSink.toggle_ignoring_sigint_v2_engine(True)

src/python/pants/engine/rules.py

@@ -242,8 +242,8 @@ def rule_decorator(*args, **kwargs) -> Callable:
 def validate_parameter_types(func_id: str, parameter_types: Tuple[Type, ...], cacheable: bool) -> None:
   if cacheable:
     for ty in parameter_types:
-      if getattr(ty, "uncacheable", False):
-        raise ValueError(f"Non-console `@rule` {func_id} has an uncacheable parameter: {ty}")
+      if getattr(ty, "side_effecting", False):
+        raise ValueError(f"Non-console `@rule` {func_id} has a side-effecting parameter: {ty}")
 
 
 def inner_rule(*args, **kwargs) -> Callable:

tests/python/pants_test/engine/test_rules.py

@@ -87,16 +87,16 @@ async def a_goal_rule_generator(console: Console) -> Example:
 
 
 class RuleTest(TestBase):
-  def test_run_rule_console_rule_generator(self):
+  def test_run_rule_goal_rule_generator(self):
     res = run_rule(
       a_goal_rule_generator,
       rule_args=[Console()],
       mock_gets=[MockGet(product_type=A, subject_type=str, mock=lambda _: A())],
     )
     self.assertEquals(res, Example(0))
 
-  def test_uncacheable_inputs(self) -> None:
-    @console_rule
+  def test_side_effecting_inputs(self) -> None:
+    @goal_rule
     def valid_rule(console: Console, b: str) -> Example:
       return Example(exit_code=0)
 
@@ -106,7 +106,7 @@ def invalid_rule(console: Console, b: str) -> bool:
         return False
 
     error_str = str(cm.exception)
-    assert "invalid_rule has an uncacheable parameter" in error_str
+    assert "invalid_rule has a side-effecting parameter" in error_str
     assert "pants.engine.console.Console" in error_str