Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[engine] bug fix: ensure we catch all exceptions in subprocess
We intended to catch all subprocesses exceptions, for example the test case EngineTest.test_multiprocess_unpickleable checks SerializationError, but some later added code wasn't protected, including line #159 that caused #3149 test to hang. This review fixes this by moving everything into the same try block. This review does not fix the root cause of #3149 but next time it happens the subprocess won't die and will report the exception back to the engine. Testing Done: https://travis-ci.org/peiyuwang/pants/builds/121229553 passed. Bugs closed: 3149, 3155 Reviewed at https://rbcommons.com/s/twitter/r/3656/
- Loading branch information