Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default invalid lockfile behaviour to error #12552

Closed
chrisjrn opened this issue Aug 12, 2021 · 1 comment
Closed

Set default invalid lockfile behaviour to error #12552

chrisjrn opened this issue Aug 12, 2021 · 1 comment
Labels
blocked

Comments

@chrisjrn
Copy link
Contributor

After setting the default behaviour to error during development work for #12448, our CI stopped passing. I've since changed the behaviour back to warn in order to land the PR.

To address, we should clear out all invalid lockfile warnings from our CI runs, and once we've achieved that, change the default behaviour to error. This can be addressed after #12542 is complete.
@chrisjrn chrisjrn mentioned this issue Aug 19, 2021
Merged
Eric-Arellano pushed a commit that referenced this issue Aug 19, 2021
Stop fetching a lockfile request just to figure out the requirements …
63eee64 
…digest (#12607)

This is our first step towards being able to switch on failure for invalid lockfiles (references #12552). 

Things to look for:

* Removal of `Get` calls for `PythonLockfileRequest` on Python tools
* Calculates the expected requirements digest in `PythonToolBase.pex_requirements()`, rather than requiring it to be passed into `pex_requirements()`.

[ci skip-rust]
[ci skip-build-wheels]
@huonw
Copy link
Contributor

huonw commented May 21, 2023

I think this was fixed in #12686 🎉

@huonw huonw closed this as completed May 21, 2023
@kaos kaos changed the title Set default invalid lockfile behaviour to errror Set default invalid lockfile behaviour to error May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisjrn @huonw