Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala types not extract from lambdas in method signatures #13663

Closed
stuhood opened this issue Nov 18, 2021 · 1 comment · Fixed by #13685
Closed

Scala types not extract from lambdas in method signatures #13663

stuhood opened this issue Nov 18, 2021 · 1 comment · Fixed by #13685

Comments

@stuhood
Copy link
Member

stuhood commented Nov 18, 2021

In:

abstract class ApplyConverter[L] {
  type In
  def apply(f: In): L => Route
}

... Route is not extracted.
@tdyas tdyas mentioned this issue Nov 20, 2021
Merged
tdyas pushed a commit that referenced this issue Nov 22, 2021
[internal] scala: extract type names from all Type.* AST nodes (#13685)
a8d9ff3 
As described in #13663, the Scala parser for dependency inference was not extracting consumed type names from more complex type syntax. This was because the initial version of the parser did not process all Type.* AST nodes. This PR does.

Fixes #13663
@stuhood
Copy link
Member Author

stuhood commented Nov 30, 2021

This represented roughly 2.5% of the issues in akka-http.

@stuhood stuhood mentioned this issue Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[internal] scala: extract type names from all Type.* AST nodes tdyas/pants
1 participant
@stuhood