Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reported cycle for native cycle detection is incorrect #13744

Closed
stuhood opened this issue Nov 30, 2021 · 0 comments · Fixed by #14381
Closed

Reported cycle for native cycle detection is incorrect #13744

stuhood opened this issue Nov 30, 2021 · 0 comments · Fixed by #14381
Assignees
@stuhood
Labels
bug

Comments

@stuhood
Copy link
Member

stuhood commented Nov 30, 2021

#13370 broke the native cycle detection error message: see #13743 (comment)

Test coverage for that code has wobbled back and forth between covering the Rust and Python code at various points, but Python currently does the file-address aware cycle detection, and so currently has the coverage.
@stuhood stuhood added the bug label Nov 30, 2021
@stuhood stuhood self-assigned this Nov 30, 2021
@stuhood stuhood mentioned this issue Nov 30, 2021
Merged
@stuhood stuhood mentioned this issue Feb 6, 2022
Merged
stuhood added a commit that referenced this issue Feb 7, 2022
@stuhood
Fix native cycle detection error message. (#14381)
8af3480 
As described in #13744, #13370 broke the error message for native cycle detection, by reporting unrelated nodes.

Fix the issue (node ids for the running subgraph were being used with the underlying graph when rendering the path) and expand the test.

Fixes #13744.

[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuhood stuhood

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix native cycle detection error message. stuhood/pants
1 participant
@stuhood