Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala symbols declared in package object end up in wrong scope #13753

Closed
stuhood opened this issue Nov 30, 2021 · 1 comment · Fixed by #13809
Closed

Scala symbols declared in package object end up in wrong scope #13753

stuhood opened this issue Nov 30, 2021 · 1 comment · Fixed by #13809
Assignees

Comments

@stuhood
Copy link
Member

stuhood commented Nov 30, 2021

When a package object is declared:

package akka.http.scaladsl

package object marshalling {
  type ToEntityMarshaller[T] = ...
}

... akka.http.scaladsl.ToEntityMarshaller is extracted as the declared symbol, which is missing the additional marshalling nesting.

@stuhood
Copy link
Member Author

stuhood commented Nov 30, 2021

This represented roughly 5% of the issues in akka-http.

@tdyas tdyas self-assigned this Dec 5, 2021
tdyas pushed a commit that referenced this issue Dec 6, 2021
Handle `package object` syntax in the Scala parser used by dependency inference.

Closes #13753.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants