Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala/java: consolidate compilation of wrapper binaries #13879

Open
tdyas opened this issue Dec 14, 2021 · 1 comment
Open

scala/java: consolidate compilation of wrapper binaries #13879

tdyas opened this issue Dec 14, 2021 · 1 comment
Labels
backend: JVM JVM backend-related issues

Comments

@tdyas
Copy link
Contributor

tdyas commented Dec 14, 2021

The Scala backend currently has multiple examples of rules that use wrapper programs written in Scala or Java to accomplish build-related tasks. For example, (1) the Scala protobuf codegen rules use a Scala shim binary to invoke the ScalaPB compiler; and (2) dependency inference for both Java and Scala use programs written in those languages, respectively, to parse source code to extract symbols.

We should refactor the rules that build those programs to use a set of common rules as makes sense.

@tdyas
Copy link
Contributor Author

tdyas commented Dec 14, 2021

Idea: Have the engine provide targets (via scala_sources, java_sources, and whatever jar-producing target type is needed) that can be built using the regular compilation rules in the Scala and Java backends.

tdyas pushed a commit that referenced this issue Dec 14, 2021
…13883)

Add TODOs related to consolidating compilation of wrapper binaries in common rules as per #13879.

[ci skip-rust]

[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: JVM JVM backend-related issues
Projects
None yet
Development

No branches or pull requests

1 participant