Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LockfileMetadata class hierarchy to make it easier to implement new metadata versions correctly #14219

Closed
chrisjrn opened this issue Jan 20, 2022 · 0 comments · Fixed by #14229
Closed

Refactor LockfileMetadata class hierarchy to make it easier to implement new metadata versions correctly #14219

chrisjrn opened this issue Jan 20, 2022 · 0 comments · Fixed by #14229
Assignees
@chrisjrn

Comments

@chrisjrn
Copy link
Contributor

Currently, the _header_dict() method on LockfileMetadata needs to be called at all levels of the class hierarchy in order to function correctly. This results in a lot of guardrails being necessary, and we can probably avoid that.
@chrisjrn chrisjrn mentioned this issue Jan 20, 2022
Merged
@chrisjrn chrisjrn self-assigned this Jan 20, 2022
@chrisjrn chrisjrn mentioned this issue Jan 21, 2022
Merged
chrisjrn pushed a commit that referenced this issue Jan 21, 2022
LockfileMetadata - Replace flaky _header_dict() mechanism with mo…
e30239d 
…re robust `header_attrs` mechanism (#14229)

Here's my first effort at replacing the flaky header_dict mechanism in LockfileMetadata with something that doesn't break spectacularly if you don't call super() and amend the resulting dict in each level of the class hierarchy. The hierarchy is still somewhat messy, and that might be the subject of a future refactor.

Closes #14219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisjrn chrisjrn

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@chrisjrn