Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

produced an invalid result on all configured command runners error message seen in CI #15888

Closed
tdyas opened this issue Jun 21, 2022 · 2 comments

Comments

@tdyas
Copy link
Contributor

tdyas commented Jun 21, 2022

I saw error message produced an invalid result on all configured command runners in a CI run at https://github.com/pantsbuild/pants/runs/6990227161?check_suite_focus=true#step:11:303. There was no additional context. If there is additional failure information from the stderr/stdout of one of the failures, we should log that.

@tdyas
Copy link
Contributor Author

tdyas commented Jun 21, 2022

cc @stuhood

@stuhood
Copy link
Member

stuhood commented Jun 21, 2022

Will be addressed by #15867.

@stuhood stuhood closed this as completed Jun 21, 2022
stuhood added a commit that referenced this issue Jun 21, 2022
)

As described in #15867 (and reported in #15885 and #15888), backtracking for missing digests currently suffers from a race condition where if multiple consuming nodes observe a `MissingDigest`, the producing node may be restarted multiple times, leading to some backtracking levels being skipped.

To address this, the backtracking level (née "attempt") is recorded in the result value, and is incremented exactly once per observation of a `MissingDigest` for a particular node and level, rather than once per run of the producing node (which can be restarted for multiple reasons, including cancellation).

[ci skip-build-wheels]
tdyas pushed a commit to tdyas/pants that referenced this issue Jun 22, 2022
…tsbuild#15889)

As described in pantsbuild#15867 (and reported in pantsbuild#15885 and pantsbuild#15888), backtracking for missing digests currently suffers from a race condition where if multiple consuming nodes observe a `MissingDigest`, the producing node may be restarted multiple times, leading to some backtracking levels being skipped.

To address this, the backtracking level (née "attempt") is recorded in the result value, and is incremented exactly once per observation of a `MissingDigest` for a particular node and level, rather than once per run of the producing node (which can be restarted for multiple reasons, including cancellation).

[ci skip-build-wheels]
tdyas pushed a commit that referenced this issue Jun 22, 2022
…rry pick of #15889) (#15897)

Increment the missing-digest backtracking level once per attempt (#15889)

As described in #15867 (and reported in #15885 and #15888), backtracking for missing digests currently suffers from a race condition where if multiple consuming nodes observe a `MissingDigest`, the producing node may be restarted multiple times, leading to some backtracking levels being skipped.

To address this, the backtracking level (née "attempt") is recorded in the result value, and is incremented exactly once per observation of a `MissingDigest` for a particular node and level, rather than once per run of the producing node (which can be restarted for multiple reasons, including cancellation).

[ci skip-build-wheels]

Co-authored-by: Stu Hood <stuhood@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants