Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental_shell_command can trigger consistent cache misses #17542

Closed
chrisjrn opened this issue Nov 14, 2022 · 1 comment · Fixed by #17549
Closed

experimental_shell_command can trigger consistent cache misses #17542

chrisjrn opened this issue Nov 14, 2022 · 1 comment · Fixed by #17549
Assignees
@stuhood

Comments

@chrisjrn
Copy link
Contributor

While working on #16825, we found a case where an experimental_shell_command target is consistently not cached.

To reproduce:

  1. Clone https://github.com/danxmoran/pants-yarn-install-repro
  2. Run ./pants_from_sources -ldebug run :run-yarn-install
  3. Look for: Error loading process execution result from local cache: Computed digest for Snapshot

It appears as though the bug was introduced between be00ed5 and 952235a.
@stuhood stuhood self-assigned this Nov 14, 2022
@chrisjrn
Copy link
Contributor Author

nb. git-bisect turns up d8c0488 as the culprit commit. Unclear if this is actually responsible or not.

@chrisjrn chrisjrn mentioned this issue Nov 14, 2022
Closed
@stuhood stuhood mentioned this issue Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuhood stuhood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix loading of SymlinkNodes from the Store. stuhood/pants
2 participants
@stuhood @chrisjrn