Fix loading of SymlinkNodes from the Store.
#17549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
approved these changes
Nov 15, 2022
thejcannon
reviewed
Nov 15, 2022
| @@ -613,6 +613,19 @@ impl Store { | |||
| Some((path, file_node.digest.as_ref().unwrap().try_into().unwrap())), | |||
| ) | |||
| })); | |||
| path_stats.extend(directory.symlinks.iter().map(move |link_node| { | |||
There was a problem hiding this comment.
I doubt we're adding more node types, but this is why I prefer match, so when we add new types it's obvious what needs to be updated
There was a problem hiding this comment.
Agreed. But this is a standard protobuf from REAPI, and it's not defined in terms of an enum.
thejcannon
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading
Directoryprotos from theStore, we were not loading theirSymlinkNodes, which caused a mismatching digest when loadingSnapshots which contain symlinks.Fixes #17542.