Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure while parsing pyprojectenvironment markers #18530

Closed
bobthemighty opened this issue Mar 20, 2023 · 1 comment · Fixed by #18535
Closed

Failure while parsing pyprojectenvironment markers #18530

bobthemighty opened this issue Mar 20, 2023 · 1 comment · Fixed by #18535
Assignees
@jsirois
Labels
backend: Python Python backend-related issues bug

Comments

@bobthemighty
Copy link
Contributor

Describe the bug

I'm unable to generate a lockfile when using poetry_requirements because environment markers fail to parse. I've created a minimal repro here, which does generate a lockfile with a warning, but does not include the torch dependency.

Pants version
2.15

OS
Linux

Additional info
Add any other information about the problem here, such as attachments or links to gists, if relevant.
@jsirois jsirois self-assigned this Mar 21, 2023
@jsirois
Copy link
Contributor

jsirois commented Mar 21, 2023

This is the same issue as detailed here in Pex: pex-tool/pex#2037 - for direct reference URL requirements, environment markers must be separated from the URL by a space. Right now Pants forms requirements like:

torch @ https://download.pytorch.org/whl/cpu/torch-1.9.1-cp39-none-macosx_11_0_arm64.whl;(platform_machine == 'arm64' and sys_platform == 'darwin')

@jsirois jsirois added the backend: Python Python backend-related issues label Mar 21, 2023
jsirois added a commit to jsirois/pants that referenced this issue Mar 21, 2023
@jsirois
Fix Poetry req synthesis for URLs with markers.
e1b05d1 
Previously the PEP-508 direct reference URL requirement synthesis ran
afoul of creating ambiguous requirement strings as detailed here:
pypa/packaging#456 (comment)

Fixes pantsbuild#18530
@jsirois jsirois mentioned this issue Mar 21, 2023
Merged
jsirois added a commit that referenced this issue Mar 21, 2023
@jsirois
Fix Poetry req synthesis for URLs with markers. (#18535)
54fb80b 
Previously the PEP-508 direct reference URL requirement synthesis ran
afoul of creating ambiguous requirement strings as detailed here:
pypa/packaging#456 (comment)

Fixes #18530
jsirois added a commit to jsirois/pants that referenced this issue Mar 21, 2023
@jsirois
Fix Poetry req synthesis for URLs with markers. (Cherry-pick of pants…
8bcab52 
…build#18535)

Previously the PEP-508 direct reference URL requirement synthesis ran
afoul of creating ambiguous requirement strings as detailed here:
pypa/packaging#456 (comment)

Fixes pantsbuild#18530

(cherry picked from commit 54fb80b)
jsirois added a commit to jsirois/pants that referenced this issue Mar 21, 2023
@jsirois
Fix Poetry req synthesis for URLs with markers. (Cherry-pick of pants…
fd04209 
…build#18535)

Previously the PEP-508 direct reference URL requirement synthesis ran
afoul of creating ambiguous requirement strings as detailed here:
pypa/packaging#456 (comment)

Fixes pantsbuild#18530

(cherry picked from commit 54fb80b)
This was referenced Mar 21, 2023
Merged
Merged
jsirois added a commit to jsirois/pants that referenced this issue Mar 21, 2023
@jsirois
Fix Poetry req synthesis for URLs with markers. (Cherry-pick of pants…
a7b7a85 
…build#18535)

Previously the PEP-508 direct reference URL requirement synthesis ran
afoul of creating ambiguous requirement strings as detailed here:
pypa/packaging#456 (comment)

Fixes pantsbuild#18530

(cherry picked from commit 54fb80b)

[ci skip-rust]

[ci skip-build-wheels]
@jsirois jsirois mentioned this issue Mar 21, 2023
Merged
jsirois added a commit that referenced this issue Mar 21, 2023
@jsirois
Fix Poetry req synthesis for URLs with markers. (Cherry-pick of #18535)…
1704a2a 
… (#18536)

Previously the PEP-508 direct reference URL requirement synthesis ran
afoul of creating ambiguous requirement strings as detailed here:
pypa/packaging#456 (comment)

Fixes #18530

(cherry picked from commit 54fb80b)
jsirois added a commit that referenced this issue Mar 21, 2023
@jsirois
Fix Poetry req synthesis for URLs with markers. (Cherry-pick of #18535)…
5362293 
… (#18537)

Previously the PEP-508 direct reference URL requirement synthesis ran
afoul of creating ambiguous requirement strings as detailed here:
pypa/packaging#456 (comment)

Fixes #18530

(cherry picked from commit 54fb80b)
jsirois added a commit that referenced this issue Mar 21, 2023
@jsirois
Fix Poetry req synthesis for URLs with markers. (Cherry-pick of #18535)…
2c02397 
… (#18538)

Previously the PEP-508 direct reference URL requirement synthesis ran
afoul of creating ambiguous requirement strings as detailed here:
pypa/packaging#456 (comment)

Fixes #18530

(cherry picked from commit 54fb80b)

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
backend: Python Python backend-related issues bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Poetry req synthesis for URLs with markers. jsirois/pants
2 participants
@bobthemighty @jsirois