Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove safe_create_dir(_all) #18548

Closed
stuhood opened this issue Mar 22, 2023 · 0 comments · Fixed by #18605
Closed

Remove safe_create_dir(_all) #18548

stuhood opened this issue Mar 22, 2023 · 0 comments · Fixed by #18605
Labels
good first issue

Comments

@stuhood
Copy link
Sponsor Member

stuhood commented Mar 22, 2023 •
edited
Loading

The safe_create_dir(_all) functions that we maintain were imported from rustc before rust-lang/rust#39799 was fixed. It should now be safe to remove them in favor of the tokio::fs::create_dir(_all) implementation (which wraps the stdlib implementation).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove safe_create_dir(_all) in favor of stdlib implementation. stuhood/pants
1 participant
@stuhood