Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack traces in union rules or anything called from a union rule are being swallowed #20460

Closed
ndellosa95 opened this issue Jan 25, 2024 · 0 comments · Fixed by #20517
Closed
Assignees
Labels
Milestone

Comments

@ndellosa95
Copy link
Contributor

ndellosa95 commented Jan 25, 2024

Describe the bug
When doing plugin development locally, I noticed I stopped getting proper stack traces sometimes and just got

Traceback (most recent call last):
  File "/Users/nick.dellosa/Library/Caches/nce/695a0515ecce6747a3e42742caf246ea42091f11bfbdd8d95ea0903e90eb510a/bindings/venvs/2.19.0rc5/lib/python3.9/site-packages/pants/core/goals/package.py", line 165, in package_asset
    packages = await MultiGet(
  File "/Users/nick.dellosa/Library/Caches/nce/695a0515ecce6747a3e42742caf246ea42091f11bfbdd8d95ea0903e90eb510a/bindings/venvs/2.19.0rc5/lib/python3.9/site-packages/pants/engine/internals/selectors.py", line 374, in MultiGet
    return await _MultiGet(tuple(__arg0))
  File "/Users/nick.dellosa/Library/Caches/nce/695a0515ecce6747a3e42742caf246ea42091f11bfbdd8d95ea0903e90eb510a/bindings/venvs/2.19.0rc5/lib/python3.9/site-packages/pants/engine/internals/selectors.py", line 172, in __await__
    result = yield self.gets
<actual error here>

I was able to do some experimentation and narrow this done to only occurring in union rules or rules called from union rules. And it seems to effect both plugins and backends built into Pants.

You can reproduce this issue by just throwing any Python error from any union rule or rule called from a union rule. Then try it with a goal rule or rule called from a goal rule and you'll see a proper stack trace.

Pants version
2.19.0rc5 and 2.19.0

OS
Intel Mac

Additional info
Add any other information about the problem here, such as attachments or links to gists, if relevant.

@ndellosa95 ndellosa95 added the bug label Jan 25, 2024
@ndellosa95 ndellosa95 changed the title Errors in union rules or anything called from a union rule are being swallowed Stack traces in union rules or anything called from a union rule are being swallowed Jan 25, 2024
@tgolsson tgolsson added this to the 2.19.x milestone Jan 30, 2024
@tgolsson tgolsson self-assigned this Feb 9, 2024
tgolsson added a commit that referenced this issue Feb 12, 2024
Fixes #20460. Caused by PyO3/pyo3#3327.

Nothing in the [changelog](https://pyo3.rs/v0.20.0/changelog.html)
stands out to me as a super-immediate need so doing the minimal upgrade.
tgolsson added a commit that referenced this issue Feb 12, 2024
Fixes #20460. Caused by PyO3/pyo3#3327.

Nothing in the [changelog](https://pyo3.rs/v0.20.0/changelog.html)
stands out to me as a super-immediate need so doing the minimal upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants