Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to isort 4.3.4 to pickup python3 stdlib imports #6149

Closed
jsirois opened this issue Jul 17, 2018 · 1 comment
Closed

Upgrade to isort 4.3.4 to pickup python3 stdlib imports #6149

jsirois opened this issue Jul 17, 2018 · 1 comment
Assignees
@jsirois

Comments

@jsirois
Copy link
Contributor

jsirois commented Jul 17, 2018

Triggered by #6092 and upgrading will allow undoing #6148
@jsirois jsirois self-assigned this Jul 17, 2018
@jsirois jsirois mentioned this issue Jul 17, 2018
Closed
@jsirois
Copy link
Contributor Author

jsirois commented Jul 17, 2018

pantsbuild/binaries#76

@jsirois jsirois removed their assignment Jul 17, 2018
@jsirois jsirois self-assigned this Jul 17, 2018
jsirois added a commit to jsirois/pants that referenced this issue Jul 17, 2018
@jsirois
Upgrade to isort 4.3.4.
52bc4f9 
This picks up python3 std lib module knowledge.

In addition, remove the un-needed isort 3rdparty dep and the
contrib/python/src/python/pants/contrib/python/isort binary. The isort
pex is now directly built via script in pantsbuild/binaries.

Fixes pantsbuild#6149
@jsirois jsirois mentioned this issue Jul 17, 2018
Merged
stuhood pushed a commit that referenced this issue Jul 18, 2018
@jsirois
Upgrade to isort 4.3.4. (#6166)
1ad39c1 
This picks up python3 std lib module knowledge.

In addition, remove the un-needed isort 3rdparty dep and the
contrib/python/src/python/pants/contrib/python/isort binary. The isort
pex is now directly built via script in pantsbuild/binaries.

Fixes #6149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsirois