Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PantsRequirement environment markers are broken for 1.10.0.dev5 #6448

Closed
jsirois opened this issue Sep 4, 2018 · 0 comments
Closed

PantsRequirement environment markers are broken for 1.10.0.dev5 #6448

jsirois opened this issue Sep 4, 2018 · 0 comments
Assignees
Labels

Comments

@jsirois
Copy link
Contributor

jsirois commented Sep 4, 2018

Until these two bits of release.sh are updated to unpin pants and its contribs from 2.7:

PKG_PANTS=(
"pantsbuild.pants"
"//src/python/pants:pants-packaged"
"pkg_pants_install_test"
"--python-tag cp27 --plat-name $(find_plat_name)"
)

run_local_pants setup-py \
--run="bdist_wheel ${BDIST_WHEEL_FLAGS:---python-tag py27}" \

The pants_requirement macro must emit environment markers that constrain the requirement to 2.7 as well:

env_marker = "python_version>='3.4' or (python_version>='2.7' and python_version<'3')"

@jsirois jsirois self-assigned this Sep 4, 2018
jsirois added a commit to jsirois/pants that referenced this issue Sep 4, 2018
These need to match our released wheels.

Fixes pantsbuild#6448
jsirois added a commit to jsirois/pants that referenced this issue Sep 4, 2018
These need to match our released wheels.

Fixes pantsbuild#6448
jsirois added a commit to jsirois/pants that referenced this issue Sep 5, 2018
These need to match our released wheels.

Fixes pantsbuild#6448
jsirois added a commit that referenced this issue Sep 5, 2018
These need to match our released wheels.

Fixes #6448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant