Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 UI Hides cursor after finishing. #6808

Closed
blorente opened this issue Nov 26, 2018 · 1 comment
Closed

V2 UI Hides cursor after finishing. #6808

blorente opened this issue Nov 26, 2018 · 1 comment

Comments

@blorente
Copy link
Contributor

While working on #6004, one comes across this problem more often than I'd like. Running the v2 UI malforms the output, and hides cursor afterwards:

malformed output

It would be great to solve this before continuing, it's hard to debug otherwise. I'll prioritise it.
@blorente blorente mentioned this issue Nov 26, 2018
Merged
stuhood pushed a commit that referenced this issue Nov 26, 2018
@blorente
Fix disappearing cursor (#6811)
95ea9fc 
### Problem

When running a rule under the V2 UI, the cursor disappeared at the end, leaving the terminal unusable for further commands.

### Solution

Flush the terminal as the last thing it does in `finish()`.


### Result

Even though the output of a `@console_rule` is still broken, the cursor appears after calling pants, which makes it a lot nicer to work on this.

![screenshot 2018-11-26 at 16 14 11](https://user-images.githubusercontent.com/5861182/49026669-56e47000-f196-11e8-9b4d-11d6fc26166e.png)

Part 1 of #6808
@stuhood
Copy link
Member

stuhood commented Nov 27, 2018

Fixed in #6811. Thanks!

@stuhood stuhood closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuhood @blorente