Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to pex 1.6.x #6927

Closed
jsirois opened this issue Dec 13, 2018 · 0 comments · Fixed by #7186
Closed

Upgrade to pex 1.6.x #6927

jsirois opened this issue Dec 13, 2018 · 0 comments · Fixed by #7186
Assignees
@jsirois

Comments

@jsirois
Copy link
Contributor

jsirois commented Dec 13, 2018

We should pick up the improved hermeticity / dropping of the need to resolve extras and add them to interpreters.
@jsirois jsirois added the python label Dec 13, 2018
@jsirois jsirois self-assigned this Dec 13, 2018
jsirois added a commit to jsirois/pants that referenced this issue Dec 13, 2018
@jsirois
PythonToolPrepBase now sets up its interpreter.
982f1f8 
Previously it was relying on the good graces of the underlying
interpreter running Pants in combination with the demands of resolving
the particular requirements needed by the tool in question.

Simplify the code by eliminating `_create_requirements` target injection
and just passing PythonRequirements directly to PexBuilderWrapper.

Prep work for pantsbuild#6927
@jsirois jsirois mentioned this issue Dec 13, 2018
Merged
jsirois added a commit to jsirois/pants that referenced this issue Dec 13, 2018
@jsirois
Upgrade to pex 1.6.0.
30d9372 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927.
@jsirois jsirois mentioned this issue Dec 13, 2018
Closed
jsirois added a commit that referenced this issue Dec 14, 2018
@jsirois
PythonToolPrepBase now sets up its interpreter. (#6928)
78a5269 
Previously it was relying on the good graces of the underlying
interpreter running Pants in combination with the demands of resolving
the particular requirements needed by the tool in question.

Simplify the code by eliminating `_create_requirements` target injection
and just passing PythonRequirements directly to PexBuilderWrapper.

Prep work for #6927
@jsirois jsirois mentioned this issue Dec 14, 2018
Closed
@jsirois jsirois closed this as completed Jan 25, 2019
@jsirois jsirois reopened this Jan 25, 2019
jsirois pushed a commit to jsirois/pants that referenced this issue Jan 28, 2019
@jsirois
Upgrade to pex 1.6.1.
abbe711 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois pushed a commit to jsirois/pants that referenced this issue Jan 30, 2019
@jsirois
Upgrade to pex 1.6.1.
9ea0b37 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
@jsirois jsirois mentioned this issue Jan 30, 2019
Merged
jsirois added a commit to jsirois/pants that referenced this issue Feb 14, 2019
@jsirois
Upgrade to pex 1.6.2.
5ed91d6 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Feb 14, 2019
@jsirois
Upgrade to pex 1.6.2.
d2422bc 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Feb 19, 2019
@jsirois
Upgrade to pex 1.6.2.
6a49326 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Feb 20, 2019
@jsirois
Upgrade to pex 1.6.2.
3e96028 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Feb 22, 2019
@jsirois
Upgrade to pex 1.6.2.
aff5194 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Mar 22, 2019
@jsirois
Upgrade to pex 1.6.2.
8597761 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Mar 26, 2019
@jsirois
Upgrade to pex 1.6.2.
4d0f027 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Mar 29, 2019
@jsirois
Upgrade to pex 1.6.2.
64c58e5 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Apr 3, 2019
@jsirois
Upgrade to pex 1.6.2.
6d666af 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Apr 3, 2019
@jsirois
Upgrade to pex 1.6.2.
1e27867 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Apr 4, 2019
@jsirois
Upgrade to pex 1.6.2.
9399425 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Apr 4, 2019
@jsirois
Upgrade to pex 1.6.2.
6977886 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Apr 5, 2019
@jsirois
Upgrade to pex 1.6.2.
305fed1 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Apr 5, 2019
@jsirois
Upgrade to pex 1.6.2.
32b870a 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Apr 5, 2019
@jsirois
Upgrade to pex 1.6.2.
cfc2be5 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Apr 13, 2019
@jsirois
Upgrade to pex 1.6.2.
ec19432 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit to jsirois/pants that referenced this issue Apr 14, 2019
@jsirois
Upgrade to pex 1.6.6.
203612d 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache.

Fixes pantsbuild#6927
jsirois added a commit that referenced this issue Apr 16, 2019
@jsirois
Upgrade to pex 1.6.6. (#7186)
4dafc87 
This allows us to get rid of resolving setuptools and wheel in our
interpreter cache and generally adapts us to more modern hermetic pex
distributions.

In addition pants now:
1. Takes over old-style namespace package injection when building pexes.
   Pex used to do this, but really only for Pants use cases. The code
   was stripped from Pex and moved into PexBuilderWrapper.
2. Exposes the new Pex --emit-warnings option to python_binary.
   By default, Pex warns about various unseemly characteristics of built
   pexes discovered when bootstrapping their run-time. Pants now plumbs
   both a global PythonSetup option and a local python_binary option to
   control the pex warning behavior of pexes it builds.

Fixes #6927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to pex 1.6.6. jsirois/pants
1 participant
@jsirois