Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate @rule(...) in favor of @rule. #8338

Closed
2 tasks done
jsirois opened this issue Sep 25, 2019 · 1 comment
Closed
2 tasks done

Deprecate @rule(...) in favor of @rule. #8338

jsirois opened this issue Sep 25, 2019 · 1 comment

Comments

@jsirois
Copy link
Contributor

jsirois commented Sep 25, 2019 •
edited by Eric-Arellano
Loading

As a follow-up to ##8330 we should deprecate the original parameterized @rule(...) decorator in favor of the new support for a bare @rule decorator applied to a fully type-parameterized function:

  1. Eliminate all existing uses of the original form by pants itself.
  2. Add a deprecation warning when theoriginal form is used.
@jsirois jsirois mentioned this issue Sep 25, 2019
Merged
@stuhood stuhood mentioned this issue Sep 27, 2019
Closed
@Eric-Arellano Eric-Arellano self-assigned this Sep 28, 2019
@Eric-Arellano Eric-Arellano mentioned this issue Sep 28, 2019
Merged
Eric-Arellano added a commit that referenced this issue Sep 29, 2019
@Eric-Arellano
Deprecate @rule(...) in favor of @rule (#8360)
b7fa166 
Implements #8338.
@Eric-Arellano
Copy link
Contributor

Closed by #8360.

@Eric-Arellano Eric-Arellano removed their assignment Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsirois @Eric-Arellano