Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isAlive has been deprecated and removed in Python 3.9 . Use is_alive. #9687

Closed
tirkarthi opened this issue May 3, 2020 · 1 comment · Fixed by #9727
Closed

isAlive has been deprecated and removed in Python 3.9 . Use is_alive. #9687

tirkarthi opened this issue May 3, 2020 · 1 comment · Fixed by #9727
Assignees
@Eric-Arellano

Comments

@tirkarthi
Copy link

Ref : python/cpython#15225

src/python/pants/bin/daemon_pants_runner.py
215:                    if writer.isAlive():

tests/python/pants_test/pantsd/service/test_pants_service.py
49:        self.assertTrue(t.isAlive())
53:        self.assertFalse(t.isAlive())
@Eric-Arellano Eric-Arellano self-assigned this May 8, 2020
@Eric-Arellano Eric-Arellano mentioned this issue May 8, 2020
Merged
@Eric-Arellano
Copy link
Contributor

Thank you for reporting this! Opened #9727.

Eric-Arellano added a commit that referenced this issue May 9, 2020
@Eric-Arellano
Fix deprecated use of Thread.isAlive() (#9727)
cd79df9 
Closes #9687.

[ci skip-rust-tests]
[ci skip-jvm-tests]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eric-Arellano Eric-Arellano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecated use of Thread.isAlive() Eric-Arellano/pants
2 participants
@tirkarthi @Eric-Arellano