Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak DescendantAddresses so that call sites can no-op when no matches #10012

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Tweak DescendantAddresses so that call sites can no-op when no matches #10012

merged 2 commits into from
Jun 10, 2020

Commits on Jun 10, 2020

  1. Do not error when :: does not match any targets 

    # Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @Eric-Arellano
    Eric-Arellano committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    4425f6d View commit details
    Browse the repository at this point in the history

  2. Rework approach. Don't change CLI behavior and let call sites change … 

    …error behavior

# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @Eric-Arellano
    Eric-Arellano committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    9159a7a View commit details
    Browse the repository at this point in the history