Remove pyopenssl, parametrized, and wheel dependencies
#10023
Conversation
This was only being used to pin a transitive dep. We don't need to do this anymore because `requests` is more up-to-date. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
It's better to use Pytest parametrization. Note that this only works with top-level modules, but that's okay because we want to encourage this style for all new tests. Tests that still need to use class-based tests can parametrize through other means like inner helper functions. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
| @@ -3,13 +3,12 @@ | |||
|
|
|||
There was a problem hiding this comment.
No changes made to this file beyond converting from unitTest-style to Pytest-style.
We don't use it for anything # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
Eric-Arellano
changed the title
pyopenssl and parametrized dependencies from pantsbuild.pantspyopenssl, parametrized, and wheel dependencies from pantsbuild.pants
Eric-Arellano
changed the title
pyopenssl, parametrized, and wheel dependencies from pantsbuild.pantspyopenssl, parametrized, and wheel dependencies
|
Hm, re: |
The core Pants wheel does not contain Pants own test code anyhow so should never carry dependencies that are only used by Pants own tests. More generally, if its valid to remove a Pants dependency (tests run, etc.) for Pants own sake, then its valid generally and will be properly reflected in published dists automatically. I may be missing something about your concern though. |
|
Ah, good point Stu. I think, John, that he was clarifying a false claim about this resulting in a smaller distribution to end-users. But, yeah, regardless of that benefit, I think we should still remove |
Aha - the last sentence of your description. Everything makes sense now. Watch the use of too many justifications! False ones are super confusing. |
|
yay! thanks! |
pyopensslwas only being used to pin a transitive dep back in 2017. We don't need to do this anymore becauserequestsis more up-to-date. We should also be using a constraints file for this purpose, rather thanrequirements.txt.parametrizedis similar to Pytest's parametrization feature. Because we want to encourage tests to use Pytest-style, it's better to use that instead. While Pytest cannot parametrize class-based tests, those can be parametrized through other means like inner helper functions.wheelwas not being used by anything.