Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate dependency cycles when using the v2 engine #10046

Closed
wants to merge 7 commits into from
Closed

Tolerate dependency cycles when using the v2 engine #10046

wants to merge 7 commits into from

Commits on Jun 13, 2020

  1. Tolerate dependency cycles with v2 

    # Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @Eric-Arellano
    Eric-Arellano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    a744577 View commit details
    Browse the repository at this point in the history

  2. Tolerate dependency cycles with v1 too 

    # Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @Eric-Arellano
    Eric-Arellano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    0622a95 View commit details
    Browse the repository at this point in the history

  3. Add tests 

    # Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @Eric-Arellano
    Eric-Arellano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    407c1b4 View commit details
    Browse the repository at this point in the history

  4. Declare dep cycle in engine/ 

    # Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @Eric-Arellano
    Eric-Arellano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    9fe4c4e View commit details
    Browse the repository at this point in the history

  5. Fix fmt 

    # Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
    @Eric-Arellano
    Eric-Arellano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    5ad192e View commit details
    Browse the repository at this point in the history

  6. Revert "Declare dep cycle in engine/" 

    This reverts commit 9fe4c4e.

Turns out, v1 cannot handle dep cycles when running `test`.
[ci skip-rust-tests]
[ci skip-jvm-tests]
    @Eric-Arellano
    Eric-Arellano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    c1a34aa View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. Revert "Tolerate dependency cycles with v1 too" 

    This reverts commit 0622a95.

[ci skip-rust-tests]
[ci skip-jvm-tests]
    @Eric-Arellano
    Eric-Arellano committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    4658736 View commit details
    Browse the repository at this point in the history