Add support for MyPy to Pants v2 #10132
Conversation
[ci skip-rust-tests] [ci skip-jvm-tests]
It resulted in every file in the result being prefixed by `src`. Not good! [ci skip-rust-tests] [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
There was a problem hiding this comment.
Thanks!
A key decision of this PR is to add MyPy to the lint goal, rather than a new typecheck goal. Users shared feedback that they prefer this, as it's neat to run all your linters in parallel. Technically, MyPy is a linter, only a supercharged one.
Not a blocker, but one other possibility that would be interesting to explore before 2.0 would be to allow for some parallelism between goal rules for the portions that don't have sideeffects. That would allow for something like ./pants check lint to run both the check and lint goals in parallel, but to actually complete the goals (ie, render their outputs, affect the filesystem) in a specified order.
I'm pretty sure that it can be made to work... just a question of whether it would be desirable to expose this interface. It would have advantages for other workflows as well, such as ./pants test lint, etc.
Interesting. For the sake of MyPy, users I think also liked the less typing of only But I agree that that would be a neat feature. Doesn't seem blocked by 2.0 though - we would be improving parallelism, and not changing the final result. |
The relation to 2.0 is just that moving |
This is not a perfect implementation yet. See #10131 for remaining TODOs. But, this gives an initial implementation to build off of.
A key decision of this PR is to add MyPy to the
lintgoal, rather than a newtypecheckgoal. Users shared feedback that they prefer this, as it's neat to run all your linters in parallel. Technically, MyPy is a linter, only a supercharged one.To activate, add
pants.backend.python.lint.mypytobackend_packages2.