Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control PATH and PEX_PYTHON_PATH seperately. #10489

Merged

Commits on Jul 28, 2020

  1. Control PATH and PEX_PYTHON_PATH seperately.

    Previously we used PATH to steer interpreter selection for hermetic PEX
    bootstrap and runtime. This led to fragile or impossible to solve
    setups.
    
    Switch to using PEX_PYTHON_PATH to both discover a bootstrap
    interpreter and steer runtime interpreter selection. Introduce a
    find_binary rule to facilitate this that uses ~portable bash for now.
    Also introduce a PexRuntimeEnvironment to steer bootstrap interpreter
    probing and allow specification of the PATH that should be exposed to
    the PEX runtime environment.
    
    Fixes pantsbuild#9760
    
    # Rust tests and lints will be skipped. Delete if not intended.
    [ci skip-rust]
    
    # Building wheels and fs_util will be skipped. Delete if not intended.
    [ci skip-build-wheels]
    jsirois committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    0afdbb8 View commit details
    Browse the repository at this point in the history
  2. Fix up remoting config.

    # Rust tests and lints will be skipped. Delete if not intended.
    [ci skip-rust]
    
    # Building wheels and fs_util will be skipped. Delete if not intended.
    [ci skip-build-wheels]
    jsirois committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    b5d4009 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Merge branch 'master' of github.com:pantsbuild/pants into interpreter…

    …_search_path/dont_stomp_PATH
    
    # Conflicts:
    #	src/python/pants/backend/awslambda/python/awslambda_python_rules.py
    #	src/python/pants/backend/python/lint/bandit/rules.py
    #	src/python/pants/backend/python/lint/black/rules.py
    #	src/python/pants/backend/python/lint/docformatter/rules.py
    #	src/python/pants/backend/python/lint/flake8/rules.py
    #	src/python/pants/backend/python/lint/isort/rules.py
    #	src/python/pants/backend/python/lint/pylint/rules.py
    #	src/python/pants/backend/python/rules/coverage.py
    #	src/python/pants/backend/python/rules/download_pex_bin.py
    #	src/python/pants/backend/python/rules/hermetic_pex.py
    #	src/python/pants/backend/python/rules/pex.py
    #	src/python/pants/backend/python/rules/pytest_runner.py
    #	src/python/pants/backend/python/rules/run_setup_py.py
    #	src/python/pants/backend/python/typecheck/mypy/rules.py
    #	src/python/pants/engine/process.py
    
    [ci skip-rust]
    [ci skip-build-wheels]
    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    dd3d39b View commit details
    Browse the repository at this point in the history
  2. Small tweaks + add a requested TODO

    [ci skip-rust]
    [ci skip-build-wheels]
    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    0f23fe9 View commit details
    Browse the repository at this point in the history
  3. Other small fixes, including adding a missing docstring

    [ci skip-rust]
    [ci skip-build-wheels]
    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    6ed4e42 View commit details
    Browse the repository at this point in the history
  4. Debug the $PATH for docker linux build

    [ci skip-rust]
    [ci skip-build-wheels]
    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    19c2154 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' of github.com:pantsbuild/pants into interpreter…

    …_search_path/dont_stomp_PATH
    
    [ci skip-rust]
    [ci skip-build-wheels]
    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    9a2aaa4 View commit details
    Browse the repository at this point in the history
  6. More debugging

    [ci skip-rust]
    [ci skip-build-wheels]
    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    2b8757b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5d4cc11 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2d0525d View commit details
    Browse the repository at this point in the history
  9. Fix bug in setting PATH

    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    53d5780 View commit details
    Browse the repository at this point in the history
  10. Remove debugging

    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    264aa51 View commit details
    Browse the repository at this point in the history
  11. Remove unused logger

    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    2411f46 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c81afad View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ade7efb View commit details
    Browse the repository at this point in the history
  14. Merge branch 'master' of github.com:pantsbuild/pants into interpreter…

    …_search_path/dont_stomp_PATH
    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    43b34d4 View commit details
    Browse the repository at this point in the history
  15. Fix fmt

    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    4ed9ea0 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e3d0332 View commit details
    Browse the repository at this point in the history
  17. Generalize finding the first path out of all matching paths

    This will be useful in other contexts too.
    Eric-Arellano committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    4ac4fb7 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    1643cb7 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Review feedback

    [ci skip-rust]
    [ci skip-build-wheels]
    Eric-Arellano committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    8051955 View commit details
    Browse the repository at this point in the history