Fix file metadata fsync. #10571
Closed
Fix file metadata fsync. #10571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously our materialize_directory tail end fsync could wipe out file metadata if the os had already flushed the initial create. Thread through the full create metadata to allow our tail end fsync to be faithful. Fixes pantsbuild#10507 [ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
…ild#10568)" This reverts commit 7499b02. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously our materialize_directory tail end fsync could wipe out file
metadata if the os had already flushed the initial create. Thread
through the full create metadata to allow our tail end fsync to be
faithful.
Fixes #10507
[ci skip-build-wheels]