Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure MyPy always runs with at least Python 3.6. #10602

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Ensure MyPy always runs with at least Python 3.6. #10602

merged 1 commit into from
Aug 13, 2020

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Aug 12, 2020

MyPy only requires Python 3.5 but we have lots of code that uses Python 3.6
features which will not parse under Python 3.5. As such bump the default
interpreter constraints to be compatible with both MyPy and our codebase.

This will be fixed correctly as part of #10131.

[ci skip-rust]
[ci skip-build-wheels]

@jsirois
Ensure MyPy always runs with at least Python 3.6.
f4b5aa6 
MyPy only requires Python 3.5 but we have lots of code that uses Python 3.6
features which will not parse under Python 3.5. As such bump the default
interpreter constraints to be compatible with both MyPy and our codebase.

This will be fixed correctly as part of pantsbuild#10131.

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@jsirois jsirois requested a review from Eric-Arellano August 12, 2020 23:56
@jsirois
Copy link
Contributor Author

jsirois commented Aug 12, 2020

This fixes a latent CI error seen by #10577 here: https://travis-ci.com/github/pantsbuild/pants/jobs/371308918

...
16:19:08 [INFO] Starting: Run MyPy on 490 files.
16:19:10 [INFO] Completed: Run MyPy on 490 files.
𐄂 MyPy failed.
build-support/bin/bootstrap_and_deploy_ci_pants_pex.py:22:13: error: Format
strings are only supported in Python 3.6 and greater  [syntax]
                f"{Path.cwd()}."
                ^
Found 1 error in 1 file (checked 485 source files)
...

@jsirois jsirois mentioned this pull request Aug 12, 2020
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling f4b5aa6 on jsirois:issues/10131/hack-around-incorrect-interpreter-picked-by-mypy-rules into 05c3fd2 on pantsbuild:master.

@jsirois jsirois merged commit 287b977 into pantsbuild:master Aug 13, 2020
@jsirois jsirois deleted the issues/10131/hack-around-incorrect-interpreter-picked-by-mypy-rules branch August 13, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsirois @coveralls @Eric-Arellano