Fix Rust 3rdparty logs showing up with --dynamic-ui
#10640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
Aug 18, 2020
| use_color: AtomicBool::new(true), | ||
| use_color: AtomicBool::new(false), |
There was a problem hiding this comment.
I figure it's safer to default to not using color until we know for certain that it's safe to enable.
Comment on lines
-193
to
+204
| if callback(&log_string).is_err() { | ||
| let handler_res = callback(&log_string); | ||
| if handler_res.is_err() { |
There was a problem hiding this comment.
I made this change to try to make more obvious that callback() has a side effect.
gshuflin
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if
--dynamic-uiwas set and-ldebug, we would get messages like:This was because filtering of 3rd party modules happening in
MaybeWriteLogger, which isn't used by the dynamic UI.This also renames the logger variables to be less generic so that we can more clearly distinguish between our own abstractions vs. upstream crates.
[ci skip-build-wheels]