Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to TestBase #10647

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Add type hints to TestBase #10647

merged 3 commits into from
Aug 19, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Aug 18, 2020

Problem

Need more typing.

Solution

Add some typing to some functions.

Result

More typing!

add some typing
6374eef 
[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas mentioned this pull request Aug 18, 2020
Closed
Eric-Arellano
Eric-Arellano approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Btw, that PR template is optional. Sometimes it makes sense, but you don't need to use it if it doesn't.

src/python/pants/testutil/test_base.py Outdated Show resolved Hide resolved
@Eric-Arellano Eric-Arellano changed the title add some typing Add type hints to TestBase Aug 18, 2020
tdyas and others added 2 commits August 18, 2020 12:23
@tdyas @Eric-Arellano
Update src/python/pants/testutil/test_base.py
6e6561d 
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
type fix
4885fe8 
[ci skip-rust]

[ci skip-build-wheels]
@coveralls
Copy link

coveralls commented Aug 18, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling 4885fe8 on tdyas:some_light_typing into d5801ae on pantsbuild:master.

@Eric-Arellano Eric-Arellano merged commit de7d5c3 into pantsbuild:master Aug 19, 2020
@tdyas tdyas deleted the some_light_typing branch November 11, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdyas @coveralls @Eric-Arellano