Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noisy log messages from @rule params #10658

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Reduce noisy log messages from @rule params #10658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d8a9d6
fix gigantic Params
gshuflin Aug 19, 2020
596122e
CR feedback
gshuflin Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/rust/engine/src/nodes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,11 @@ impl Display for NodeKey {
&NodeKey::Scandir(ref s) => write!(f, "Scandir({})", (s.0).0.display()),
&NodeKey::Select(ref s) => write!(f, "{}", s.product),
&NodeKey::Task(ref task) => {
write!(f, "@rule {}({})", task.task.display_info.name, task.params)
// TODO(#7907) we probably want to include some kind of representation of
// the Params of an @rule when we stringify the @rule. But we need to make
// sure we don't naively dump the string representation of a Key, which
// could get gigantic.
write!(f, "@rule({})", task.task.display_info.name)
}
&NodeKey::Snapshot(ref s) => write!(f, "Snapshot({})", s.0),
}
Expand Down