Deprecate python_binary in favor of pex_binary
#10939
Conversation
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
requested review from
jsirois,
benjyw,
tdyas,
illicitonion and
asherf
| f"Use the target type `pex_binary`, rather than `python_binary` for {address}. " | ||
| "The behavior is identical." |
There was a problem hiding this comment.
I originally wanted to add a sed snippet, but gave up. Sed has some differences between macOS and Linux that I personally find hard to navigate.
The snippet is easy with rg and sd (modern Rust alternative), but too few users have those installed.
Distributing a Python script felt super overkill.
--
Lmk if we should in fact add some snippet, or at least the regex ^python_binary\(.
There was a problem hiding this comment.
We use sed -Ee "..." for mac and linux in out own scripts successfully and stably. Did you need some sed feature beyond -E extended regexps?:
$ git grep -w sed *.sh
build-support/bin/contributors.sh: | sed -e 's/;.*$//'
build-support/bin/contributors.sh: sed -E -e "s|^|+ |" >> CONTRIBUTORS.md
build-support/bin/release-changelog-helper.sh: sed -Ee "s|^\(#([0-9]+)\)$|https://github.com/pantsbuild/pants/pull/\1|"
build-support/bin/release-changelog-helper.sh: sed -Ee "s|^.*(https?://[^ ]+).*$|\1|" | \
build-support/bin/release-changelog-helper.sh: sed -Ee "s|[/\.]+$||"
build-support/bin/release.sh: PEX_VERSION="$(requirement pex | sed -e "s|pex==||")"
There was a problem hiding this comment.
sed -Ee 's#^python_binary\(#pex_binary(#g' would work I think? I wonder if #9434 would become more tolerable now since we already have libcst as a dependency? It would be able to act on BUILD files that aren't perfectly formatted is all (where ^python_binary() may not necessarily catch all of them).
There was a problem hiding this comment.
A suggestion for after the 2.0 release is I believe how to appropriately consider #9434.
There was a problem hiding this comment.
Thank you John and Danny for the help!
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Reasons:
python_binaryis not some magical thing; it is an interface around the Pex tool.__init__.pyhandling.We want to make this change before 2.0 is released to the world.
[ci skip-rust]
[ci skip-build-wheels]