Modernize scheduler_test.py and process_test.py
#11117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
force-pushed
the
port-tests
branch
from
08371ec to
ee85864
Compare
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
Nov 9, 2020
Comment on lines
-43
to
-44
| @dataclass(frozen=True) | ||
| class Concatted: |
There was a problem hiding this comment.
The below code was all deleted. It's no longer necessary now that we dogfood the engine so much. Too much complexity to be worth keeping.
|
|
||
| def test_multiple_file_creation(self): | ||
| digest = self.request( | ||
| def test_argv_executable(rule_runner: RuleRunner) -> None: |
There was a problem hiding this comment.
The test_executable and test_not_executable tests were merged into this.
| QueryRule(FallibleProcessResult, (Process,)), | ||
| ) | ||
|
|
||
| def test_input_file_creation(self): |
There was a problem hiding this comment.
This was merged with test_multiple_file_creation and test_file_in_directory_creation into a single test lower in the file.
Comment on lines
-221
to
-223
| def test_env(self): | ||
| req = Process(argv=("foo",), description="Some process", env={"VAR": "VAL"}) | ||
| assert dict(req.env) == {"VAR": "VAL"} |
There was a problem hiding this comment.
This original test wasn't really testing much..rewritten to be more comprehensive.
| assert dict(req.env) == {"VAR": "VAL"} | ||
| def test_env(rule_runner: RuleRunner) -> None: | ||
| with environment_as(VAR1="VAL"): | ||
| process = Process(argv=("/usr/bin/env",), description="", env={"VAR2": "VAL"}) |
There was a problem hiding this comment.
I checked that this is the correct path on both Linux and macOS.
Comment on lines
-270
to
+100
| def test_fallible_failing_command_returns_exited_result(self): | ||
| request = Process(argv=("/bin/bash", "-c", "exit 1"), description="one-cat") | ||
| def test_failing_process(rule_runner: RuleRunner) -> None: |
There was a problem hiding this comment.
I merged this test with test_non_fallible_failing_command_raises.
gshuflin
approved these changes
Nov 10, 2020
Merged
Eric-Arellano
added a commit
that referenced
this pull request
Nov 10, 2020
This leaves off these internal only changes: * Remove the examples/ directory. (#11100) `PR #11100 <https://github.com/pantsbuild/pants/pull/11100>`_ * Upgrade toml from 0.10.1 to 0.10.2 (#11097) `PR #11097 <https://github.com/pantsbuild/pants/pull/11097>`_ * Modernize `scheduler_test.py` and `process_test.py` (#11117) [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites them to use
RuleRunner/Pytest, and also removes some complexity inprocess_test.py.[ci skip-rust]
[ci skip-build-wheels]