Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to Rust v1.48.0 #11210

Merged
merged 3 commits into from
Nov 21, 2020
Merged

upgrade to Rust v1.48.0 #11210

merged 3 commits into from
Nov 21, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Nov 19, 2020

Upgrade to Rust v1.48.0. https://blog.rust-lang.org/2020/11/19/Rust-1.48.html

  • Disabled clippy::manual_strip which is triggered now in code generated by the macros in the cpython crate.
  • Disabled clippy::rc_buffer in code that put a Vec<PathStat> in an Arc.

[ci skip-build-wheels]

stuhood
stuhood approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/rust/engine/src/nodes.rs Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 19, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling e8b3bed on tdyas:rust_v1.48.0 into 9a441d8 on pantsbuild:master.

Tom Dyas added 2 commits November 19, 2020 20:54
upgrade to Rust v1.48.0
01facf1 
[ci skip-build-wheels]
add comment
f9486d2 
[ci skip-build-wheels]
@tdyas
Copy link
Contributor Author

tdyas commented Nov 20, 2020

One shard is failing consistently but I can't tell why from the logs: https://travis-ci.com/github/pantsbuild/pants/jobs/444139748

Could someone else take a look? What am I missing?

@stuhood
Copy link
Member

stuhood commented Nov 20, 2020

One shard is failing consistently but I can't tell why from the logs: https://travis-ci.com/github/pantsbuild/pants/jobs/444139748

The output is pretty busted, but it looks like it's rustfmt failing for:

/home/travis/build/pantsbuild/pants/src/rust/engine/testutil/mock/src/action_cache.rs
/home/travis/build/pantsbuild/pants/src/rust/engine/workunit_store/src/metrics.rs

The ./build-support/bin/check_rust_formatting.sh script is pretty hacky unfortunately... it's possible that cargo fmt has improved enough that it can be simplified at this point?

fmt
e8b3bed 
[ci skip-build-wheels]
@tdyas
Copy link
Contributor Author

tdyas commented Nov 20, 2020

Okay pushed the formatting fix.

it's possible that cargo fmt has improved enough that it can be simplified at this point?

Yes, we could just run cargo fmt --check and it will error exit if formatting needs to be done.

@tdyas tdyas merged commit 009d8bf into pantsbuild:master Nov 21, 2020
@tdyas tdyas deleted the rust_v1.48.0 branch November 21, 2020 00:07
@Eric-Arellano Eric-Arellano mentioned this pull request Nov 24, 2020
Merged
Eric-Arellano added a commit that referenced this pull request Nov 25, 2020
@Eric-Arellano
Prepare 2.2.0.dev0 (#11239)
aa0f8ee 
Internal only changes:

* Rewrite changelog helper to Python and use markdown for changelog ([#11224](#11224))

* Update to nails `0.8.0`. ([#11226](#11226))

* upgrade to Rust v1.48.0 ([#11210](#11210))

* Move Session to its own file. ([#11222](#11222))

* Port InteractiveProcess to Tokio to unblock async interruption ([#11219](#11219))

* Add `./cargo` script to facilitate Rust development ([#11218](#11218))

* Add partition metadata ([#11212](#11212))

* Hotfix unbound `$PY` variable breaking cargo script ([#11209](#11209))

* Remove dataclasses backport ([#11208](#11208))

* Stop using Python 3.6 internally and in CI ([#11175](#11175))

* Update to tokio 0.2.23. ([#11200](#11200))

* Add test address metadata ([#11193](#11193))

* Port more tests from `TestBase` to `RuleRunner` ([#11183](#11183))

* acquire GIL during work unit conversion ([#11186](#11186))

* Add counter metrics for remote execution  ([#11155](#11155))

* add metrics to local cache code paths ([#11146](#11146))

* Deprecate the `sources` field for `python_awslambda` ([#11176](#11176))

* Make S3 bucket expiry deletion handling robust. ([#11156](#11156))

* Detect delete markers in our s3 cache of native_engine.so. ([#11140](#11140))

* Fix target globs for deleted file `pants_run_integration_test.py`. ([#11127](#11127))

* Deduplicate `Platform` and `PlatformConstraint` ([#11157](#11157))

* move counter increment into check_action_cache ([#11154](#11154))

* Replace the "base target" concept with "BUILD targets" ([#11136](#11136))

* Re-land the port of Pants' nailgun client to Rust ([#11147](#11147))

* Flatten execution and target PlatformConstraints in MultiPlatformProcess ([#11145](#11145))

* Prepare 2.1.0rc2 ([#11180](#11180))

* Prepare 2.1.0rc1 ([#11144](#11144))

* Prepare 2.0.1rc0 ([#11141](#11141))

* Prepare 2.0.1rc2 ([#11220](#11220))

* Prepare 2.1.1rc0 ([#11221](#11221))

* Prepare 2.1.0 ([#11198](#11198))

* Prepare 2.0.1rc1 ([#11192](#11192))

* Prepare 2.1.0rc3 ([#11191](#11191))

[ci skip-rust]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshuflin gshuflin gshuflin approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@stuhood stuhood stuhood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tdyas @coveralls @stuhood @Eric-Arellano @gshuflin