Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move graph cycle detection to rust. (#11202)" (cherrypick of #11272) #11277

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Dec 8, 2020

#11202 introduced a lot of contention on the GIL that was only obvious when larger numbers of targets were being built. #11270 is a holistic fix for that issue, but it is currently blocked on #11269.

In the meantime, we will land #11271 to dodge the original issue in #11201 to get us back to a medium-slow-but-working state, and then follow up on #11269 and #11270 to get us to the best place.

This reverts commit fabcb45.

[ci skip-build-wheels]

…sbuild#11272)

In the meantime, we will land pantsbuild#11271 to dodge the original issue in pantsbuild#11201 to get us back to a medium-slow-but-working state, and then follow up on pantsbuild#11269 and pantsbuild#11270 to get us to the best place.

This reverts commit fabcb45.

[ci skip-build-wheels]
@stuhood stuhood force-pushed the stuhood/pick-11272-for-2.0.x branch from 89cc4cd to 95d1c53 Compare December 9, 2020 03:21
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 95d1c53 on stuhood:stuhood/pick-11272-for-2.0.x into ac3bc44 on pantsbuild:2.0.x.

@stuhood stuhood merged commit d2cd521 into pantsbuild:2.0.x Dec 9, 2020
@stuhood stuhood deleted the stuhood/pick-11272-for-2.0.x branch December 9, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants