Reduce FFI boilerplate for ExecutionRequest, PySession, and PyTasks
#11700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
Mar 16, 2021
Comment on lines
-139
to
-138
| def write_log(self, msg: str, *, level: int, target: str): | ||
| """Proxy a log message to the Rust logging faculties.""" | ||
| return self.lib.write_log(msg, level, target) | ||
|
|
||
| def flush_log(self): | ||
| return self.lib.flush_log() |
| def new_tasks(self) -> PyTasks: | ||
| return PyTasks() | ||
|
|
||
| def new_execution_request(self) -> PyExecutionRequest: | ||
| return PyExecutionRequest() | ||
|
|
||
| def new_session( |
| @@ -187,51 +190,6 @@ def _to_params_list(self, subject_or_params): | |||
| return subject_or_params.params | |||
| return [subject_or_params] | |||
|
|
|||
| def _register_rules(self, rule_index: RuleIndex, union_membership: UnionMembership): | |||
There was a problem hiding this comment.
Moved to a free function at the bottom of the file.
Comment on lines
-292
to
-301
| def execution_set_timeout(self, execution_request, timeout: float): | ||
| timeout_in_ms = int(timeout * 1000) | ||
| self._native.lib.execution_set_timeout(execution_request, timeout_in_ms) | ||
|
|
||
| def execution_set_poll(self, execution_request, poll: bool): | ||
| self._native.lib.execution_set_poll(execution_request, poll) | ||
|
|
||
| def execution_set_poll_delay(self, execution_request, poll_delay: float): | ||
| poll_delay_in_ms = int(poll_delay * 1000) | ||
| self._native.lib.execution_set_poll_delay(execution_request, poll_delay_in_ms) |
There was a problem hiding this comment.
Now directly specified in the PyExecutionRequest constructor.
| @@ -679,3 +624,48 @@ def get_observation_histograms(self): | |||
|
|
|||
| def record_test_observation(self, value: int) -> None: | |||
| self._scheduler.record_test_observation(self._session, value) | |||
|
|
|||
|
|
|||
| def register_rules(rule_index: RuleIndex, union_membership: UnionMembership) -> PyTasks: | |||
There was a problem hiding this comment.
Lmk if there's a better place to put this. Maybe native.py? We won't need the Native singleton because CPython allows us to directly access native_engine.so, and we are slowly getting rid of Externs, but we could still use that file to collect helper functions like this?
There was a problem hiding this comment.
This should be fine... exploding access to native_engine out across multiple modules makes sense, because if we could (easily) split native_engine we would.
Eric-Arellano
changed the title
ExecuteRequest, PySession, and PyTasksExecutionRequest, PySession, and PyTasks
gshuflin
approved these changes
Mar 16, 2021
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
approved these changes
Mar 16, 2021
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings us closer to idiomatic CPython usage and also adds Python type hints to these types.