Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to debug RuleRunner tests. #11748

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Make it easier to debug RuleRunner tests. #11748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fc257b
Make it easier to debug RuleRunner tests.
jsirois Mar 19, 2021
0a66b24
Kill failed attempt at logging cruft.
jsirois Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 33 additions & 8 deletions src/python/pants/testutil/rule_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import multiprocessing
import os
import sys
from contextlib import contextmanager
from dataclasses import dataclass
from io import StringIO
Expand Down Expand Up @@ -91,10 +92,29 @@ def __init__(
objects: dict[str, Any] | None = None,
context_aware_object_factories: dict[str, Any] | None = None,
isolated_local_store: bool = False,
preserve_tmpdirs: bool = False,
ca_certs_path: str | None = None,
bootstrap_args: Iterable[str] = (),
) -> None:
self.build_root = os.path.realpath(mkdtemp(suffix="_BUILD_ROOT"))
safe_mkdir(self.build_root, clean=True)

bootstrap_args = [*bootstrap_args]

root_dir: Path | None = None
if preserve_tmpdirs:
root_dir = Path(mkdtemp(prefix="RuleRunner."))
print(f"Preserving rule runner temporary directories at {root_dir}.", file=sys.stderr)
bootstrap_args.extend(
[
"--no-process-execution-cleanup-local-dirs",
f"--local-execution-root-dir={root_dir}",
]
)
build_root = (root_dir / "BUILD_ROOT").resolve()
build_root.mkdir()
self.build_root = str(build_root)
else:
self.build_root = os.path.realpath(safe_mkdtemp(prefix="_BUILD_ROOT"))

safe_mkdir(self.pants_workdir)
BuildRoot().path = self.build_root

Expand All @@ -117,14 +137,19 @@ def __init__(
self.build_config = build_config_builder.create()

self.environment = CompleteEnvironment({})
self.options_bootstrapper = create_options_bootstrapper()
self.options_bootstrapper = create_options_bootstrapper(args=bootstrap_args)
options = self.options_bootstrapper.full_options(self.build_config)
global_options = self.options_bootstrapper.bootstrap_options.for_global_scope()
local_store_dir = (
os.path.realpath(safe_mkdtemp())
if isolated_local_store
else global_options.local_store_dir
)

local_store_dir = global_options.local_store_dir
if isolated_local_store:
if root_dir:
lmdb_store_dir = root_dir / "lmdb_store"
lmdb_store_dir.mkdir()
local_store_dir = str(lmdb_store_dir)
else:
local_store_dir = safe_mkdtemp(prefix="lmdb_store.")

local_execution_root_dir = global_options.local_execution_root_dir
named_caches_dir = global_options.named_caches_dir

Expand Down