Never cancel branch builds for main and release branches
#11750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
commented
Mar 19, 2021
Comment on lines
20
to
+25
| NUM_RUST_FILES=$(echo "${CHANGED_FILES})" | grep -c -E \ | ||
| -e "^src/rust/engine" \ | ||
| -e "^rust-toolchain" \ | ||
| -e "^build-support/bin/rust" \ | ||
| -e "^build-support/bin/generate_travis_yml.py") | ||
| -e "^build-support/bin/generate_travis_yml.py" \ | ||
| -e "^build-support/bin/generate_github_workflows.py") |
There was a problem hiding this comment.
I want to replace this with GitHub Action's first-class support for this, but in the meantime..
Comment on lines
-45
to
-51
| if [[ "${HAS_CI_SKIP}" -eq 1 ]] && [ "${NUM_NON_MD_FILES}" -eq 0 ]; then | ||
| cat <<EOF >> "${COMMIT_MSG_FILEPATH}" | ||
|
|
||
| # All CI will be skipped. Delete if not intended. | ||
| [ci skip] | ||
| EOF | ||
| fi |
There was a problem hiding this comment.
Unconsumed in GitHub config. Also we rarely update .md files anymore, so not really relevant.
benjyw
approved these changes
Mar 19, 2021
Merged
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Mar 21, 2021
Shellcheck was complaining: ``` In ./build-support/githooks/prepare-commit-msg line 39: HAS_CI_SKIP=$? ^---------^ SC2034: HAS_CI_SKIP appears unused. Verify use (or export if used externally). ``` This appears to be leftovers from pantsbuild#11750. [ci skip-rust] [ci skip-build-wheels]
jsirois
added a commit
that referenced
this pull request
Mar 21, 2021
Shellcheck was complaining: ``` In ./build-support/githooks/prepare-commit-msg line 39: HAS_CI_SKIP=$? ^---------^ SC2034: HAS_CI_SKIP appears unused. Verify use (or export if used externally). ``` This appears to be leftovers from #11750.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up #11747 so that we always build for
mainand release branches, even if a newer commit lands during a CI run.