[internal] Rename generate-lockfiles to gen-lockfiles
#12680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
IMO, let's just leave these with the obviously temporary names until the semantics are settled in #12591. As described there, if we're going for |
|
Sure, that's fine with me. Ideally you aren't running these goals much either, unlike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12641 for why we're using this naming scheme of
generate-lockfilesinstead of something more succinct likelock. tl;dr: the semantics for lockfiles will improve in Pants 2.8+, e.g. autogenerating the lockfile when necessary, and we don't want to commit to a highly generic name till that is all worked out.Still, @benjyw pointed out in #12676 that
gen-lockfilesis more concise thangenerate-lockfilesand probably does not lose much clarity. We already use the "gen" abbrevation, likeexport-codegen. Note thatgen-lockfilesis still a verb, which we want for goal names.[ci skip-rust]
[ci skip-build-wheels]