-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [tool].lockfile
(e.g. [black].lockfile
) for Python tools and activate ./pants generate-lockfiles
by default
#12684
Add [tool].lockfile
(e.g. [black].lockfile
) for Python tools and activate ./pants generate-lockfiles
by default
#12684
Conversation
…activate `./pants generate-lockfiles` by default # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@@ -85,23 +85,25 @@ def register_options(cls, register): | |||
) | |||
if cls.register_lockfile: | |||
register( | |||
"--experimental-lockfile", | |||
"--lockfile", | |||
type=str, | |||
default=NO_TOOL_LOCKFILE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was supposed to change to DEFAULT_TOOL_LOCKFILE
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, in a followup. I want a dedicated changelog entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it. Sorry, saw the bullets in the description, and missed that they were followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there's both DEFAULT
and NO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisjrn I think Stu is saying something different. We do want to change the default to be DEFAULT_TOOL_LOCKFILE
instead of NO_TOOL_LOCKFILE
. Only I'm doing that in a followup PR.
|
||
[isort] | ||
experimental_lockfile = "<default>" | ||
lockfile = "<default>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the default has changed to <default>
(looks like it hasn't), you should be able to remove this.
Closes #11898. We now believe tool lockfiles are stable enough to be used without the
--experimental
feature gate andexperimental.python
backend.Some remaining stabilization work:
[python-setup].invalid_lockfile_behavior
to default to error--lockfile
to<default>
[python-setup].experimental_lockfile_custom_regeneration_command
[ci skip-rust]
[ci skip-build-wheels]