Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux aarch64 wheel build support #12879

Closed
wants to merge 1 commit into from

Conversation

odidev
Copy link

@odidev odidev commented Sep 14, 2021

Added Linux AArch64 wheel build support.
Related to #12183, @Eric-Arellano Could you please review this PR?

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thank you!

Feel free to join our Slack also if you have questions and it's easier to ask there: https://www.pantsbuild.org/docs/getting-help. I'm really excited for this change and am happy to help.

cc @chrisjrn who added generic architecture-awareness to Pants 2.7, which is what unblocked this change 🎉

@@ -366,6 +366,56 @@ jobs:
name: Deploy to S3
run: ./build-support/bin/deploy_to_s3.py
timeout-minutes: 65
build_wheels_aarch64:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generate our CI files. You'll want to update build-support/bin/generate_github_workflows.py, then run ./pants run build-support/bin/generate_github_workflows.py.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -15,6 +15,7 @@ class Platform(Enum):
linux_x86_64 = "linux_x86_64"
macos_arm64 = "macos_arm64"
macos_x86_64 = "macos_x86_64"
linux_arm64 = "linux_arm64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update all uses of Platform to include linux_arm64 - this will tell Pants how to install native binaries like Protoc. See https://www.pantsbuild.org/v2.7/docs/reference-protoc#section-known-versions for instructions on computing the SHA256 and # bytes.

We won't be testing Pants aarch64 in CI because GitHub Actions doesn't have it...so that means it's going to be up to contributors to ensure things work. When adding a new binary, it would be really helpful if you're willing to test that things work locally. Lmk if I can help with figuring out how to test each thing (usually running ./pants test on its related files should do the trick).

Signed-off-by: odidev <odidev@puresoftware.com>
@benjyw
Copy link
Contributor

benjyw commented Jan 9, 2023

Superseded by #17918. Thanks @odidev !

@benjyw benjyw closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants