Release the GIL while creating a Session. #13127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
approved these changes
Oct 5, 2021
| // held. | ||
| let scheduler = scheduler.scheduler(py).clone(); | ||
| let cancellation_latch = cancellation_latch.cancelled(py).clone(); | ||
| let session = py.allow_threads(|| Session::new( |
There was a problem hiding this comment.
Is there any way to ensure the "no GIL" condition for Graph access? Should Graph methods panic if the GIL is held?
There was a problem hiding this comment.
Hm... good idea. But I don't see a way to check whether the GIL is already acquired, and it's probably not worth adding thread local state for it.
There was a problem hiding this comment.
PyO3 exposes the necessary API:
There was a problem hiding this comment.
Good call. Yea, I think peppering a reusable debug assert around would be a great idea. I'll do that in a followup though, since it would be hard to cherry pick.
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/release-gil-during-session-creation
branch
from
ca44195 to
576dee5
Compare
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Oct 6, 2021
Creating a `Session` accesses the `Graph` to get the number of valid nodes, but when created under the `PySession` wrapper, does so while holding the GIL. Release the GIL in `PySession`. [ci skip-build-wheels] Conflicts: [ci skip-jvm-tests]
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Oct 7, 2021
Creating a `Session` accesses the `Graph` to get the number of valid nodes, but when created under the `PySession` wrapper, does so while holding the GIL. Release the GIL in `PySession`. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a
Sessionaccesses theGraphto get the number of valid nodes, but when created under thePySessionwrapper, does so while holding the GIL.Release the GIL in
PySession.[ci skip-build-wheels]