Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Don't download Go third-party dependencies multiple times #13352

Merged
merged 7 commits into from
Oct 27, 2021

Commits on Oct 26, 2021

  1. [internal] Make explicit that we're redownloading Go modules multiple…

    … times
    
    # Rust tests and lints will be skipped. Delete if not intended.
    [ci skip-rust]
    
    # Building wheels and fs_util will be skipped. Delete if not intended.
    [ci skip-build-wheels]
    Eric-Arellano committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a3f31eb View commit details
    Browse the repository at this point in the history
  2. Redesign third-party dependency to not keep downloading the same modules

    # Rust tests and lints will be skipped. Delete if not intended.
    [ci skip-rust]
    
    # Building wheels and fs_util will be skipped. Delete if not intended.
    [ci skip-build-wheels]
    Eric-Arellano committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a2646a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Better error message if Dir is not defined

    # Rust tests and lints will be skipped. Delete if not intended.
    [ci skip-rust]
    
    # Building wheels and fs_util will be skipped. Delete if not intended.
    [ci skip-build-wheels]
    Eric-Arellano committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    8860a2a View commit details
    Browse the repository at this point in the history
  2. Add regression test for pantsbuild#13138

    # Rust tests and lints will be skipped. Delete if not intended.
    [ci skip-rust]
    
    # Building wheels and fs_util will be skipped. Delete if not intended.
    [ci skip-build-wheels]
    Eric-Arellano committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    5271ea6 View commit details
    Browse the repository at this point in the history
  3. Clean up some incomplete things

    # Rust tests and lints will be skipped. Delete if not intended.
    [ci skip-rust]
    
    # Building wheels and fs_util will be skipped. Delete if not intended.
    [ci skip-build-wheels]
    Eric-Arellano committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    a05f687 View commit details
    Browse the repository at this point in the history
  4. Store GOPATH digest on AllThirdPartyPackages

    # Rust tests and lints will be skipped. Delete if not intended.
    [ci skip-rust]
    
    # Building wheels and fs_util will be skipped. Delete if not intended.
    [ci skip-build-wheels]
    Eric-Arellano committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    e01c8a7 View commit details
    Browse the repository at this point in the history
  5. Fix first-party package to not download too

    # Rust tests and lints will be skipped. Delete if not intended.
    [ci skip-rust]
    
    # Building wheels and fs_util will be skipped. Delete if not intended.
    [ci skip-build-wheels]
    Eric-Arellano committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    a380172 View commit details
    Browse the repository at this point in the history