assume version 1 for older lockfiles without a version key
#13399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
chrisjrn
pushed a commit
to chrisjrn/pants
that referenced
this pull request
Oct 28, 2021
…d#13399) As reported in Slack, Python lockfiles created in Pants v2.7.x do not have a `version` key in the lockfile metadata. Pants v2.8.x generates lockfiles with the `version` key in the metdata and expects the files to contain that key. It had no fallback for older lockfiles without the `version` key. This broke an upgrade for one user from v2.7.0rc2 to v2.8.0rc0. Solution: Pants should just assume version 1 if it does not find the `version` key in lockfile metadata. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
pushed a commit
that referenced
this pull request
Oct 28, 2021
…k of #13399) (#13406) As reported in Slack, Python lockfiles created in Pants v2.7.x do not have a `version` key in the lockfile metadata. Pants v2.8.x generates lockfiles with the `version` key in the metdata and expects the files to contain that key. It had no fallback for older lockfiles without the `version` key. This broke an upgrade for one user from v2.7.0rc2 to v2.8.0rc0. Solution: Pants should just assume version 1 if it does not find the `version` key in lockfile metadata. (Backport of 184d51e to 2.8.x release branch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in Slack, Python lockfiles created in Pants v2.7.x do not have a
versionkey in the lockfile metadata. Pants v2.8.x generates lockfiles with theversionkey in the metdata and expects the files to contain that key. It had no fallback for older lockfiles without theversionkey. This broke an upgrade for one user from v2.7.0rc2 to v2.8.0rc0.Solution: Pants should just assume version 1 if it does not find the
versionkey in lockfile metadata.[ci skip-rust]