Support strong first-party declarations of provided types #13698
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
This code specifically resolves the ambiguity by having the third-party mapping return no results for |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
If we wanted to be technically correct, then yes, I guess? I didn't go looking particularly hard for how the first party symbol map works in relation to target generation, but I suspect we'd need the symbol map to be run first. I'm not sure that's doable. On the other hand, all that To prevent spurious use of the field, we may want to consider verifying that all of the (cc @tdyas) |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
^--- And the above is exactly what I've done now. |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
| def __init__(self): | ||
| self.children: dict[str, MutableTrieNode] = {} | ||
| self.recursive: bool = False | ||
| self.addresses: OrderedSet[Address] = OrderedSet() | ||
| self.first_party: bool = False |
There was a problem hiding this comment.
If we end up having the ! syntax for packages, we may want to redefine this field for more complicated exclusions, but for now, this will do.
The results from first party and third party symbol matching are merged together (and then checked for ambiguity). The order in which they are evaluated does not matter. |
| def __init__(self): | ||
| self.children: dict[str, MutableTrieNode] = {} | ||
| self.recursive: bool = False | ||
| self.addresses: OrderedSet[Address] = OrderedSet() | ||
| self.first_party: bool = False |
src/python/pants/jvm/target_types.py
Outdated
| @@ -64,6 +64,11 @@ class JvmArtifactPackagesField(StringSequenceField): | |||
| ) | |||
|
|
|||
|
|
|||
| class JvmProvidesTypesField(StringSequenceField): | |||
| alias = "experimental_provides_types" | |||
| help = "TODO: Add help for this." | |||
There was a problem hiding this comment.
Still needs to be filled in.
|
@tdyas Re supporting negation in the trie: I think we may need to map out a proper design for how to implement negation properly. I think there are actually two concepts that matter to here:
With that in mind, I'd prefer to punt on redesigning that, until we implement negation as a more general concept, so we can flesh out the design better. |
Makes sense. Agreed. |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
This reverts commit a27e44e. [ci skip-rust] [ci skip-build-wheels]
Adds a new field to
java_source(s) andscala_source(s) targets that allow them to strongly declare that they provide a specific JVM type. This excludes these types from being provided by third-party dep inference. This allows first-party sources to provide types that amend a third-party package.TODO: remove
exampleappamendmentCloses #13661