Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] Introduce OptionalPex/OptionalPexRequest. #13712

Merged
merged 1 commit into from
Nov 25, 2021
Merged

[internal] Introduce OptionalPex/OptionalPexRequest. #13712

merged 1 commit into from
Nov 25, 2021

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Nov 25, 2021 •
edited
Loading

So we can operate monadically in situations where there
may or may not be an underlying Pex.

Utilizes this in one such case we currently have - requesting
a repository pex: Previously there was no way to go from _RepositoryPexRequest
to PexRequest. This brings repository pexes more inline with other pexes - you
request them via a PexRequest, except you must also account for
the possibility that no repository pex can be used.

[ci skip-rust]

[ci skip-build-wheels]

@benjyw
Introduce OptionalPex/OptionalPexRequest.
5b87df6 
So we can operate monadically in situations where there
may or may not be an underlying Pex.

Utilizes this in one such case we currently have - requesting
a repository pex.

This brings repository pexes more inline with other pexes - you
request them via a PexRequest, except you must also account for
the possibility that no repository pex can be used.

[ci skip-rust]

[ci skip-build-wheels]
benjyw
benjyw commented Nov 25, 2021
View reviewed changes
src/python/pants/backend/python/util_rules/pex_from_targets.py
@@ -230,11 +231,6 @@ async def interpreter_constraints_for_targets(
return interpreter_constraints


@dataclass(frozen=True)
class _RepositoryPex:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we use a standard OptionalPexRequest instead

benjyw
benjyw commented Nov 25, 2021
View reviewed changes
src/python/pants/backend/python/util_rules/pex_from_targets.py
_ConstraintsRepositoryPexRequest(request),
)
if maybe_constraints_repository_pex.maybe_pex:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no need for this check even before!

@Eric-Arellano
Copy link
Contributor

Probably should be marked [internal] in PR title

@benjyw benjyw changed the title Introduce OptionalPex/OptionalPexRequest. [internal] Introduce OptionalPex/OptionalPexRequest. Nov 25, 2021
@benjyw benjyw merged commit dcb2bfa into pantsbuild:main Nov 25, 2021
@benjyw benjyw deleted the optional_pex_request branch November 25, 2021 01:02
@illicitonion illicitonion mentioned this pull request Dec 6, 2021
Merged
illicitonion added a commit that referenced this pull request Dec 7, 2021
@illicitonion
Prep for 2.9.0.dev3 (#13823)
55bbcec 
Internal changes:

* [internal] Remove superfluous f-string specifiers ([#13821](#13821))

* [internal] scala: extract annotations as consumed types ([#13810](#13810))

* [jvm] Split nailgun digest from input file digests ([#13813](#13813))

* [internal] jvm: add jre_major_version and use stderr to properly extract version ([#13812](#13812))

* [internal] Clean up Go `embed` support's handling of dependencies ([#13801](#13801))

* [internal] scala: handle package object syntax in parser ([#13809](#13809))

* [internal] java: fix junit sentinel rule setup ([#13815](#13815))

* [internal] upgrade to rust v1.57.0 ([#13807](#13807))

* [internal] add failing test for FrozenDict equality issue ([#13389](#13389))

* [internal] Use `PyObject` instead of `Value` in more places ([#13802](#13802))

* Remove MultiPlatform Process abstractions ([#12725](#12725))

* [internal] add `JvmToolBase` for lockfile handling for JVM tools ([#13777](#13777))

* [internal] Port `MergeDigests` to Rust ([#13773](#13773))

* [jvm] Spawn nailgun servers outside the pool lock ([#13796](#13796))

* [internal] DRY loading internal Go binaries ([#13800](#13800))

* [internal] Convert unit tests to use pytest ([#13798](#13798))

* [internal] remove dead code - socket util. ([#13797](#13797))

* [internal] Reorganize Go parser scripts ([#13791](#13791))

* Adds Jackson core/datatype to `JVM_ARTIFACT_MAPPINGS` ([#13792](#13792))

* [internal] go: initial support for embedding resources ([#13743](#13743))

* [internal] Refer to `go.mod` path when downloading packages ([#13786](#13786))

* [internal] More robust Go dependency inference tests ([#13785](#13785))

* [internal] `tailor` doesn't add `go_package` for `testdata` folder ([#13783](#13783))

* [internal] Add Scala backend to dryrun for wheel builds. ([#13772](#13772))

* [internal] Unify JVM thirdparty resolves ([#13771](#13771))

* [internal] scala: infer dependencies from consumed symbols and intermediate scopes ([#13758](#13758))

* [internal] java: infer scala encoded symbols ([#13739](#13739))

* [internal] scala: parse and report package scopes ([#13738](#13738))

* [internal] go: configure included env vars for `GoSdkProcess` ([#13734](#13734))

* Fix some `./cargo audit` vulnerabilities. ([#13728](#13728))

* [internal] fix non-empty __init__.py ([#13730](#13730))

* Compute RepositoryPex directly from addresses. ([#13716](#13716))

* Upgrade to cargo-audit 0.16.0. ([#13729](#13729))

* Simplify `NativeHandler`. ([#13727](#13727))

* [internal] Switch to a maintained fork of the `fuse` crate for `brfs`. ([#13679](#13679))

* [internal] Add infrastructure to support deprecating field names ([#13666](#13666))

* [internal] Introduce OptionalPex/OptionalPexRequest. ([#13712](#13712))

* [internal] tailor adds go_package targets ([#13703](#13703))

* [internal] Remove unused testproject for pants-plugin ([#13704](#13704))

* [internal] Rename ambiguous `subpath` variable for Go code ([#13701](#13701))

* [internal] scala: generate the JVM names seen by Java code for Scala code ([#13696](#13696))

* Use RequirementsPexRequest in run_pex_binary.py. ([#13693](#13693))

* [internal] Refactor finding owning `go_mod` for first-party packages ([#13695](#13695))

* [internal] repl: add append_only_caches / run_in_workspace attributes to ReplRequest ([#13599](#13599))

* [internal] switch back to official `cargo-ensure-prefix` crate ([#13692](#13692))

* [internal] scala: extract type names from all Type.* AST nodes ([#13685](#13685))

* [internal] Convert unit tests to use pytest ([#13652](#13652))

* Unblock codegen support for java export analysis (#13645) ([#13675](#13675))

* [internal] upgrade to Rust 2021 Edition ([#13644](#13644))

* [internal] Don't store derived values on `go_first_party_package` targets ([#13676](#13676))

* Upgrade to py03 0.15.1. ([#13725](#13725))

* Add PyPDF2 to module mapping ([#13717](#13717))

* Upgrade console and indacatif. ([#13726](#13726))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjyw @Eric-Arellano