Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inferring relative imports from Scala #13775

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Dec 2, 2021

Relative imports are common in Scala, and not supporting them caused ~12% of the issues in our test repository. See #13740 for background.

To support them, compares the final token of an import (or its alias, if it has one) to the first token of any multi-token symbol that is scoped below the import.

Fixes #13740.

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
[ci skip-rust]
[ci skip-build-wheels]
@stuhood stuhood merged commit 995448e into pantsbuild:main Dec 2, 2021
@stuhood stuhood deleted the stuhood/scala-relative-import branch December 2, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala partially qualified symbol not inferred
2 participants